From af9965a855a8c6c7140bbcccfa89eec7e90a993d Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Tue, 25 Feb 2025 12:16:33 +0000 Subject: [PATCH] misc: rp1-pio: Demote fw probe error to warning Support for the RP1 firmware mailbox API is rolling out to Pi 5 EEPROM images. For most users, the fact that the PIO is not available is no cause for alarm. Change the message to a warning, so that it does not appear with "quiet" in cmdline.txt. Link: https://github.com/raspberrypi/linux/issues/6642 Signed-off-by: Phil Elwell --- drivers/misc/rp1-pio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/misc/rp1-pio.c +++ b/drivers/misc/rp1-pio.c @@ -1279,8 +1279,10 @@ static int rp1_pio_probe(struct platform fw = devm_rp1_firmware_get(dev, dev->of_node); if (!fw) return dev_err_probe(dev, -EPROBE_DEFER, "failed to find RP1 firmware driver\n"); - if (IS_ERR(fw)) - return dev_err_probe(dev, PTR_ERR(fw), "failed to contact RP1 firmware\n"); + if (IS_ERR(fw)) { + dev_warn(dev, "failed to contact RP1 firmware\n"); + return PTR_ERR(fw); + } ret = rp1_firmware_get_feature(fw, FOURCC_PIO, &op_base, &op_count); if (ret < 0) return ret;