From ce759b7db6a29e36c031a6a6aedcf8ee150da8b0 Mon Sep 17 00:00:00 2001 From: Chenlei Hu Date: Fri, 25 Oct 2024 19:26:13 -0400 Subject: [PATCH] Revert download to .tmp in frontend_management (#5369) --- app/frontend_management.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/app/frontend_management.py b/app/frontend_management.py index 191408ac..6f20e439 100644 --- a/app/frontend_management.py +++ b/app/frontend_management.py @@ -168,20 +168,16 @@ class FrontendManager: Path(cls.CUSTOM_FRONTENDS_ROOT) / provider.folder_name / semantic_version ) if not os.path.exists(web_root): - # Use tmp path until complete to avoid path exists check passing from interrupted downloads - tmp_path = web_root + ".tmp" try: - os.makedirs(tmp_path, exist_ok=True) + os.makedirs(web_root, exist_ok=True) logging.info( "Downloading frontend(%s) version(%s) to (%s)", provider.folder_name, semantic_version, - tmp_path, + web_root, ) logging.debug(release) - download_release_asset_zip(release, destination_path=tmp_path) - if os.listdir(tmp_path): - os.rename(tmp_path, web_root) + download_release_asset_zip(release, destination_path=web_root) finally: # Clean up the directory if it is empty, i.e. the download failed if not os.listdir(web_root):