From 9c957977d09abf730d9aaecc5420b15941496903 Mon Sep 17 00:00:00 2001
From: hayden <48267247+hayden-fr@users.noreply.github.com>
Date: Fri, 24 Jan 2025 16:58:40 +0800
Subject: [PATCH] Repair the file operation abnormality and add a log record

---
 app/output_manager.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/output_manager.py b/app/output_manager.py
index 999adf9fb..f60229ed3 100644
--- a/app/output_manager.py
+++ b/app/output_manager.py
@@ -1,9 +1,11 @@
 from __future__ import annotations
 
 import os
+import logging
 import folder_paths
 import mimetypes
 import shutil
+import traceback
 from aiohttp import web
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from io import BytesIO
@@ -29,8 +31,8 @@ class OutputManager:
     def add_routes(self, routes) -> None:
         @routes.get("/output{pathname:.*}")
         async def get_output_file_or_files(request):
+            pathname = request.match_info.get("pathname", None)
             try:
-                pathname = request.match_info.get("pathname", None)
                 filepath = self.get_output_filepath(pathname)
 
                 if os.path.isfile(filepath):
@@ -51,13 +53,15 @@ class OutputManager:
                     return web.json_response(files)
 
                 return web.Response(status=404)
-            except Exception as e:
+            except Exception:
+                logging.error(f"File '{pathname}' retrieval failed")
+                logging.error(traceback.format_exc())
                 return web.Response(status=500)
 
         @routes.delete("/output{pathname:.*}")
         async def delete_output_file_or_files(request):
+            pathname = request.match_info.get("pathname", None)
             try:
-                pathname = request.match_info.get("pathname", None)
                 filepath = self.get_output_filepath(pathname)
 
                 if os.path.isfile(filepath):
@@ -66,7 +70,9 @@ class OutputManager:
                     shutil.rmtree(filepath)
                     self.rm_cache(filepath)
                 return web.Response(status=200)
-            except Exception as e:
+            except Exception:
+                logging.error(f"File '{pathname}' deletion failed")
+                logging.error(traceback.format_exc())
                 return web.Response(status=500)
 
     def get_output_filepath(self, pathname: str):